Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement downloads to device #672

Closed
cvan opened this issue Oct 25, 2018 · 0 comments · Fixed by #3072
Closed

Implement downloads to device #672

cvan opened this issue Oct 25, 2018 · 0 comments · Fixed by #3072
Assignees
@keianhzo
Labels
Draft Design From design team for review enhancement This issue is a new feature or request in progress Needs Design Attention design team P3 Backlog PM/UX review PM/UX review needed prior to merge size: 4
Milestone
#10 features

Comments

@cvan
Copy link
Contributor

cvan commented Oct 25, 2018 •
edited

Hardware

Oculus Go

Steps to Reproduce

  1. Attempt to download a file in Firefox Reality
  2. Notice nothing happens

Current Behavior

A file is not downloaded.

Expected Behavior

A file will be downloaded to /sdcard/Android/data/org.mozilla.vrbrowser/files/Download.

Possible Solution

Design wires and conversations are in issue #635.

Technically: When a user navigates to a URL with a response header of Content-Disposition: attachment, a mime-type that Gecko thinks is downloadable, or a user clicks on a link with a download attribute (e.g., <a href="img_1590128.png" download="screenshot.png"><img src="img_1590128.png"></a>).

There's a Downloads GeckoView Android Component for this now: https://github.com/mozilla-mobile/android-components/blob/master/components/feature/downloads/README.md

There may be additional work to be done, but let's double check that we are correctly using the Safe Browsing API so that URLs that are known to be threats cannot be downloaded.
@cvan cvan changed the title Implements Downloads (from android-components) Implement Downloads manager (from android-components) Oct 25, 2018
@philip-lamb philip-lamb added enhancement This issue is a new feature or request P2 Fix in the next development iteration and removed backlog labels Mar 11, 2019
@philip-lamb philip-lamb modified the milestones: v1.1.3, v1.2 Mar 11, 2019
@cvan cvan mentioned this issue Mar 12, 2019
Open
@cvan cvan mentioned this issue May 6, 2019
Closed
@philip-lamb philip-lamb modified the milestones: v1.2, v1.3 May 8, 2019
@philip-lamb philip-lamb added P1 Fix in the current development iteration and removed P2 Fix in the next development iteration labels May 8, 2019
@jvonitter jvonitter self-assigned this May 17, 2019
@philip-lamb philip-lamb changed the title Implement Downloads manager (from android-components) Implement downloads to device May 17, 2019
@jvonitter jvonitter added Needs Design Attention design team P3 Backlog and removed P1 Fix in the current development iteration labels May 17, 2019
@jvonitter jvonitter modified the milestones: v1.3, v1.4 Jul 2, 2019
@jvonitter jvonitter added Draft Design From design team for review and removed Needs Design Attention design team labels Jul 9, 2019
@jvonitter jvonitter added PM/UX review PM/UX review needed prior to merge and removed Needs Design Attention design team labels Jul 9, 2019
@philip-lamb philip-lamb mentioned this issue Jul 18, 2019
Closed
@jvonitter jvonitter modified the milestones: v1.4, v1.5 Aug 14, 2019
@jvonitter jvonitter modified the milestones: v1.5, Icebox Aug 22, 2019
@jvonitter jvonitter modified the milestones: Icebox, v1.x Oct 2, 2019
@bluemarvin bluemarvin mentioned this issue Feb 27, 2020
Closed
@keianhzo keianhzo modified the milestones: Backlog, #10 features Mar 3, 2020
@keianhzo keianhzo self-assigned this Mar 16, 2020
@emstanley emstanley added the Needs Design Attention design team label Mar 19, 2020
@keianhzo keianhzo mentioned this issue Apr 1, 2020
Merged
bluemarvin added a commit that referenced this issue Apr 13, 2020
@keianhzo @bluemarvin
Closes #672 Downloads support (#3072)
ee7d323 
* Downloads

* Disable HW acceleration in the tray to make downloads icon clipping work

* Rebase fixes

* Fix rebase issue

* Fix showing control panels in a new tab containing about:blank

Co-authored-by: Randall E. Barker <simstorm@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
Draft Design From design team for review enhancement This issue is a new feature or request in progress Needs Design Attention design team P3 Backlog PM/UX review PM/UX review needed prior to merge size: 4
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Closes #672 Downloads support MozillaReality/FirefoxReality
6 participants
@cvan @emstanley @keianhzo @philip-lamb @nancyhang @jvonitter