Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus hand detection #1162

Merged
merged 1 commit into from
May 9, 2019
Merged

Focus hand detection #1162

merged 1 commit into from
May 9, 2019

Conversation

bluemarvin
Copy link
Contributor

I'll rebase once #1149 lands.

@cvan cvan mentioned this pull request May 7, 2019
Closed
@bluemarvin bluemarvin force-pushed the focus-hand-detection branch 3 times, most recently from eb8dcf1 to 37a31da Compare May 8, 2019 00:24
@bluemarvin
Copy link
Contributor Author

I think this is ready for review now.

@bluemarvin
Copy link
Contributor Author

Actually, this isn't ready to land, it is broken on Oculus. Investigating.

@bluemarvin
Copy link
Contributor Author

Fixed and tested on all platforms, googlevr, oculus, and wavevr.

daoshengmu
daoshengmu approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@daoshengmu daoshengmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Show resolved Hide resolved
cvan
cvan reviewed May 9, 2019
View reviewed changes
app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Outdated Show resolved Hide resolved
app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Outdated Show resolved Hide resolved
app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Outdated Show resolved Hide resolved
app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Outdated Show resolved Hide resolved
app/src/wavevr/cpp/DeviceDelegateWaveVR.cpp Outdated Show resolved Hide resolved
app/src/main/cpp/BrowserWorld.cpp Outdated Show resolved Hide resolved
@bluemarvin bluemarvin merged commit b279469 into master May 9, 2019
@cvan cvan deleted the focus-hand-detection branch May 10, 2019 08:57
@cvan cvan added this to the v1.2 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvan cvan cvan left review comments

@daoshengmu daoshengmu daoshengmu approved these changes

@MortimerGoro MortimerGoro Awaiting requested review from MortimerGoro

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bluemarvin @cvan @daoshengmu