Add support for resizing alphabetic keyboard with based on language #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
force-pushed
the
keyboard_width
branch
from
90743e8
to
4dc1733
Compare
MortimerGoro
changed the title
daoshengmu
suggested changes
May 8, 2019
| // Fall back to english. | ||
| mCurrentKeyboard = getKeyboardForLocale(Locale.ENGLISH); | ||
| keyboard = getKeyboardForLocale(Locale.GERMAN); |
There was a problem hiding this comment.
Is this a typo? It looks like it should still be getKeyboardForLocale(Locale.ENGLISH);
There was a problem hiding this comment.
good catch, yes it was a typo (changed it for a test)
| @@ -568,10 +579,20 @@ private void handleGlobeClick() { | |||
|
|
|||
| private void handleLanguageChange(KeyboardInterface aKeyboard) { | |||
| mCurrentKeyboard = aKeyboard; | |||
| int width = getKeyboardWidth(mCurrentKeyboard.getAlphabeticKeyboardWidth()); | |||
There was a problem hiding this comment.
I would like to add "final" to when it is a constant.
| Resources resources = aContext.getResources(); | ||
| DisplayMetrics metrics = resources.getDisplayMetrics(); | ||
| float px = dp * ((float)metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT); | ||
| int px = (int) Math.ceil(dp * ((float)metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT)); | ||
| return px; |
There was a problem hiding this comment.
Maybe just return (int) Math.ceil(dp * ((float)metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT));
| SettingsStore.getInstance(getContext()).setSelectedKeyboard(aKeyboard.getLocale()); | ||
| mKeyboardView.setKeyboard(mCurrentKeyboard.getAlphabeticKeyboard()); | ||
| hideOverlays(); | ||
| updateCandidates(); | ||
|
|
There was a problem hiding this comment.
nit: remove this newline.
philip-lamb
added
enhancement
MortimerGoro
force-pushed
the
keyboard_width
branch
from
4dc1733
to
9f38ea3
Compare
MortimerGoro
force-pushed
the
keyboard_width
branch
from
9f38ea3
to
604c020
Compare
|
I fixed all issues, I'm going to merge this because I need it for other PRs. We can test the work together when we land the next keyboard updates |
|
I just confirmed it works properly on Focus Plus. Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the german keyboard I had some width space problems (they have a extra letter in the same line as
enter). I tried this as a solution but then I switched to making keys a bit smaller.I believe @daoshengmu also needs this feature for Zhuyin keybord. It may be required for russian too.