Use the same widget texture for all settings screens #1218
Conversation
MortimerGoro
force-pushed
the
settings_views
branch
from
4f92eb5
to
79ef5cc
Compare
There was a problem hiding this comment.
tested on Oculus Go and Pico G2 (WaveVR). the transition is noticeably smoother. nice work! 👍
I tested the Settings sub-menus as thoroughly as I could.
everything seems to work as fine, except when opening Settings > Controller Options, a yellow outline around the modal UI widget now consistently appears for me on WaveVR in this branch, but it is not reproducible on master (7850851) nor release-1.2 (2566225):
P.S. I mentioned this in https://vimeo.com/user41954276/review/336277352/594b11e75c#comment_7819849 for my review of PR #1211 (#1211 (review)): pressing on the region around the UI widgets for the Settings sub-menus do not trigger a dismiss action)
P.P.S. I just reopened a related issue, #1005, for this bug on WaveVR that causes yellow focus-ring outlines around UI elements after the pressed state (and yellow backgrounds during the pressed state).
|
@cvan I can't reproduce this in my Vive and Oculus devices |
|
@cvan it seems something related to accessibility or focus indicator. @bluemarvin has seen that outline in NoAPI a lot with different UIs. We can use that to reproduce it in a easier way. |
There was a problem hiding this comment.
based on the comments, I've reversing per my earlier review #1218 (review) to approve this PR.
even though the yellow outline seems to be a minor regression with these changes, I agree we can defer to this issue: #1005 (comment) (hopefully HTC doesn't have a problem with it.)
Fixes #1197