Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for display/voice/content languages #1474

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Conversation

keianhzo
Copy link
Collaborator

Fixes #794 Added support for voice/display/content languages

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me other than a few nits. The new selection page is sort of ugly though. Feels like SOME ONE IS SCREAMING AT ME.
Screen_Shot_1907315142

@keianhzo
Copy link
Collaborator Author

keianhzo commented Aug 1, 2019

@bluemarvin I think we could just not capitalize the language and just bold it. Also seeing it now I think it needs a new line so the language doesn't get cut when it's too long. I'll update with those changes.

@keianhzo
Copy link
Collaborator Author

keianhzo commented Aug 1, 2019

@bluemarvin @MortimerGoro I've updated with some changes.

@keianhzo keianhzo merged commit 451ce73 into master Aug 2, 2019
@philip-lamb philip-lamb deleted the choose_languages branch August 5, 2019 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add options for user to define Website Content Language order
3 participants