Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post firstDrawCallback to avoid a deadlock if the widget is resized in that callback. #1486

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Post firstDrawCallback to avoid a deadlock if the widget is resized in that callback. #1486

merged 1 commit into from
Aug 2, 2019

Conversation

MortimerGoro
Copy link
Contributor

@MortimerGoro MortimerGoro commented Aug 1, 2019 •
edited

fixes #1459

GeckoView deadlocks if surfaceChanged is called within the onFirstComposite call, because surfaceChanged is synchronous internally.

sync

@MortimerGoro MortimerGoro mentioned this pull request Aug 1, 2019
Closed
@MortimerGoro MortimerGoro force-pushed the postdelayed_first_composite branch 2 times, most recently from 8a00301 to f97dc6a Compare August 1, 2019 13:48
@MortimerGoro MortimerGoro mentioned this pull request Aug 1, 2019
Closed
@keianhzo keianhzo merged commit b8ccd64 into master Aug 2, 2019
@philip-lamb philip-lamb deleted the postdelayed_first_composite branch August 5, 2019 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@keianhzo keianhzo keianhzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a new window causes app to crash
3 participants
@MortimerGoro @bluemarvin @keianhzo