Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes non working reset for privacy settings #1506

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Conversation

keianhzo
Copy link
Collaborator

@keianhzo keianhzo commented Aug 5, 2019

The privacy settings were not being reset correctly.

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reset button for Privacy and Security says Reset Display Settings
Screen_Shot_1908052653

@bluemarvin
Copy link
Contributor

Environment panel also say Reset Display Settings

@keianhzo
Copy link
Collaborator Author

keianhzo commented Aug 6, 2019

Fixed reset buttons descriptions and moved out the override env button from the env scrollview.

@bluemarvin
Copy link
Contributor

I'm going to land this. If @MortimerGoro has any feedback it can be done in a follow up.

@bluemarvin bluemarvin merged commit 4cab6e4 into master Aug 6, 2019
@bluemarvin bluemarvin deleted the settings_fixes branch August 7, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants