Private windows recreation fixes #1554
Conversation
There was a problem hiding this comment.
Enabling curved mode with more than one window is intentional and and was PR #1541
|
@bluemarvin Totally missed that, I've reverted it although I have to say that without being aware it totally felt like a bug to me. |
|
I only knew about because I reviewed it. 😅 It isn’t what would expect either. |
|
This still isn't working for me. STR (easiest to repro with NoAPI):
Results: Expected: |
keianhzo
force-pushed
the
private-browsing-recreate
branch
from
3919237
to
34ab68c
Compare
|
@bluemarvin Makes sense that happens in noapi killing the app. The recent apps button triggers the onPause state but not onStop. I've moved the save state call to onPause, that should solve the issue. I've also added a fix for the ButtonPrompt that was affecting the way actions where handled for the performance monitor dialog. |
keianhzo
force-pushed
the
private-browsing-recreate
branch
from
34ab68c
to
5b3c961
Compare
|
@keianhzo I can still recreate the issue where switching to private mode and then swipe closing FxR in NoAPI. To be clear I see this on headsets too, it's just easier to reproduce with NoAPI. |
|
From an offline discussion it was noted that the private browsing session are being saved and restored and it was agreed this is probably not the desired behavior. It was agreed to wait to land this PR until that issue was addressed. |
|
@bluemarvin should work as expected now. |
There was a problem hiding this comment.
My only nit is that if you open two private browsing windows, when FxR restores, it restores two private windows, I think I would prefer it go back to one, but that is more a personal preference than anything. @jvonitter is this the expected behavior or should we address in a follow up?
Fixes #1544, Fixes #1545 and Fixes #1561 Also fixes the curved mode being activated after adding a second window if disabled and private sessions not being hidden after restoring and showing on top of the regular windows. Also cherry picked a SessionStack refactor from other of my PRs to get rid of an intermediate structure that can be avoided that also fixes some bugs when handling sessions inside the session stack.