Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Multiple window telemetry #2323

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Refine Multiple window telemetry #2323

merged 2 commits into from
Nov 27, 2019

Conversation

daoshengmu
Copy link
Contributor

Fixes #2030.

@daoshengmu
Copy link
Contributor Author

I have confirmed it works as I thought. @keianhzo Let's do the review first, then I will update our Wiki and start the data review then.

@daoshengmu daoshengmu added this to the #7 polish milestone Nov 21, 2019
@keianhzo
Copy link
Collaborator

@daoshengmu ready to start the data rwview

@daoshengmu
Copy link
Contributor Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • Frequency of window moves per session.
  • Frequency of window resizes per session.
  • Time spent in active window position, per session.
  • How long are one, two or three windows open, per session?
  • How many windows are open at a time, per session?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Establish baselines or measure changes in product or platform quality or performance.
  • Provide information essential for advancing a business objective such as supporting OKRs.
  • Determine whether a product or platform change has an effect on user or browser behavior.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A
  1. Can current instrumentation answer these questions?
  • We did it at Added Multi-window Telemetry #1443, but the current telemetry mechanism is not optimized at the client side and some data are wrong., so we need to refine them.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • I want this data to be collected for 6 months initially (potentially renewable).
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Review with UX design team to inform improvements to this feature and future feature development. Review with developers to identify bugs.
  1. Where do you intend to share the results of your analysis?
  • Only within the team.

@daoshengmu
Copy link
Contributor Author

@harraton Please help do data review, and the wiki has been updated.

@jvonitter
Copy link
Contributor

Since this data was already reviewed as part of #1329 , I think it's ok to merge as long as we didnt add any new metrics. I do still want official approval from @harraton when she's back (and we can make any necessary updates then)

@daoshengmu
Copy link
Contributor Author

We didn't add new telemetry and just refine existing ones. So. we are going to merge it and please let me know if there is other concerns, we will address it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move telemetry computation off client
3 participants