Fix leaked JNI local reference in GeckoSurfaceTexture #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
changed the title
bluemarvin
reviewed
Feb 10, 2020
Comment on lines
162
to
+163
| surface = GeckoSurfaceTexture::Create(aSurfaceHandle); | ||
| m.surfaceMap[aSurfaceHandle] = surface; |
There was a problem hiding this comment.
What condition causes us to have a aSurfaceHandle value with out it being in the m.surfaceMap?
There was a problem hiding this comment.
A new texture that hasn't been used before or StopPresenting() call which cleared the surfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a JNI reference overflow when working on exit from WebXR. This happens because exit is not working yet and the ExternalBlitter->cancelFrame() is called every frame, leading to a crash after some seconds.
The leak also happens in WebVR but in a slower pace