Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System config changes fixes #2797

Merged
merged 2 commits into from
Feb 18, 2020
Merged

System config changes fixes #2797

merged 2 commits into from
Feb 18, 2020

Conversation

keianhzo
Copy link
Collaborator

This fixes some issues that I've seen while testing v9 with language update from the system config. Fixes the correct update of the URL and Title bars.
Also fixes the correct update of app dialogs in case the system language is changed while a dialog is opened.

@MortimerGoro MortimerGoro merged commit aa2edc9 into master Feb 18, 2020
@MortimerGoro MortimerGoro deleted the v9/language_fixes branch February 18, 2020 17:17
@Softvision-GeluHaiduc
Copy link

I have verified these new behaviors using the latest RC, Firefox Reality version 9 RC2 (37ac4cb), installed on the Oculus Go, Quest, HTC Vive Focus, Focus Plus and Pico Neo2 headsets. Everything seems to be working as expected.
However, on the Pico Neo2 the placeholder for the URL bar doesn’t change languages when the device language is changed to another language besides English. I will log a separate issue for this.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants