Fixes #2853 Apply new heading to all Pico devices #2966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like too many commits were included in this PR? |
keianhzo
force-pushed
the
v10/immersive_controls_pico
branch
from
f8989bc
to
a9f3264
Compare
|
@bluemarvin updated, I think I mistakenly started this PR from another branch. |
bluemarvin
suggested changes
Mar 16, 2020
| if (m.type == kTypeNeo2) { | ||
| m.reorientMatrix = aMatrix; | ||
| } | ||
| m.reorientMatrix = aMatrix; |
There was a problem hiding this comment.
If you do this, re-center is broken on the G2.
|
closing in favor of #2973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2853 Apply new heading to all Pico devices