Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle version code conversion in debug builds #2980

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Handle version code conversion in debug builds #2980

merged 1 commit into from
Mar 18, 2020

Conversation

keianhzo
Copy link
Collaborator

Handle version code conversion in debug builds

@keianhzo keianhzo self-assigned this Mar 18, 2020
@keianhzo keianhzo added this to the #10 features milestone Mar 18, 2020
@keianhzo keianhzo added the crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak label Mar 18, 2020
@bluemarvin
Copy link
Contributor

bluemarvin commented Mar 18, 2020 •
edited

Did my change break this? I see what happened. I have taskclusterBuild=true set in user.properties so my local builds have a valid number.

@bluemarvin bluemarvin merged commit ca2092a into master Mar 18, 2020
@bluemarvin bluemarvin deleted the v10/version_code_crash branch March 18, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees

@keianhzo keianhzo

Labels
crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak
Projects
None yet
Milestone
#10 features
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keianhzo @bluemarvin