Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3169 Hide Tracking icon for file URIs #3206

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Conversation

keianhzo
Copy link
Collaborator

Fixes #3169 This PR refactors the URL buttons (etp, popups, webxr, drm) and icons (loading, ssl) visibility rules to the view model as it has grown quite a lot and makes the XML very crowded and hard to read.

Also adds a number of fixes:

  • Hides the ETP icon for file URIs
  • Hides the URL buttons if the URL bar is focused
  • Shows the file name in the title bar for file URIs (instead of just file://)

@keianhzo keianhzo self-assigned this Apr 22, 2020
@bluemarvin bluemarvin merged commit 1f805d7 into master Apr 22, 2020
@bluemarvin bluemarvin deleted the v10/etp_files branch April 22, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Tracking Protection shield icon is wrongly displayed for opened downloaded files
2 participants