Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3168 Context menu fixes #3207

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fixes #3168 Context menu fixes #3207

merged 2 commits into from
Apr 22, 2020

Conversation

keianhzo
Copy link
Collaborator

Fixes #3168

  • Don't show the context menu for blob elements (ie. Youtube video)
  • In case there is no linkUri, show srcUri as title
  • Hide linkUri related menu items (open in new window, open in tab, download link) in case is null or empty

@keianhzo keianhzo self-assigned this Apr 22, 2020
@bluemarvin bluemarvin merged commit 69a4df6 into master Apr 22, 2020
@bluemarvin bluemarvin deleted the v10/context_menu_fixes branch April 22, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

@MortimerGoro MortimerGoro Awaiting requested review from MortimerGoro

Assignees

@keianhzo keianhzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Context menu is wrongly displayed when an opened video is long clicked
2 participants
@keianhzo @bluemarvin