Fixes #3257 Fixes #3256 Make sure session listeners are set when first LoadRequest is called #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
changed the title
keianhzo
changed the title
bluemarvin
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Since setupListeners is always followed by a setSession I'd like a safer API to handle this instead of separate calls. What about adding an additional (probably optional) enum or bitflag to the SetSession call which indicates if we want to activate, deactivate or don't change active state of the session?
We can do it as a follow-up
MortimerGoro
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3257 Fixes #3256 We are setting the session listeners after activating the sessions. That means that in some cases (like restoring when activating the session) the listeners are not ready. This cause issues like permissions (or anything that we do in the session listeners) not being correctly checked for restored sessions.