Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mUri is not null in Window save #3279

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Ensure mUri is not null in Window save #3279

merged 1 commit into from
Apr 29, 2020

Conversation

bluemarvin
Copy link
Contributor

@bluemarvin bluemarvin added the crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak label Apr 28, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Apr 28, 2020
@bluemarvin bluemarvin self-assigned this Apr 28, 2020
@bluemarvin bluemarvin changed the title Ensure mUri is not null Window save Ensure mUri is not null in Window save Apr 28, 2020
Copy link
Collaborator

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing at the crash, looks like it must be that. Can we make it in a single line? like:

.filter(sessionState -> SAVE_BLACKLIST.stream().noneMatch(uri ->
                            sessionState.mUri == null || sessionState.mUri.startsWith(uri)))

@bluemarvin
Copy link
Contributor Author

Seeing at the crash, looks like it must be that. Can we make it in a single line? like:

.filter(sessionState -> SAVE_BLACKLIST.stream().noneMatch(uri ->
                            sessionState.mUri == null || sessionState.mUri.startsWith(uri)))

Shouldn't it be sessionState.mUri != null && sessionState.mUri.startsWith(uri)))

@keianhzo keianhzo merged commit 135a8ac into master Apr 29, 2020
@keianhzo keianhzo deleted the save-crash branch April 29, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants