Added support for emu x86

[keianhzo]

Added support for android x86 emulator. Ideally we could add support for flavor dimensions and have targets for abi, platforms and channels (release, beta, nightly) so we can easily test all combinations. We can do that in the future.

[bluemarvin]

This change looks like the noApi will now only build for x86? I still use the noApi for testing on arm.

[keianhzo]

@bluemarvin Fixed that and added multi flavor support as it's a more standard way of dealing with this. Haven't added support for channels as I'm not really sure we need that yet and it generates a lot of variants.

[bluemarvin]

this looks great. I wish I could do a test push to master to see if taskcluster has any problems with this before landing it for real.

[bluemarvin]

I can build all the versions of the apk with:

./gradlew --no-daemon clean assembleGooglevr assembleNoapi assembleWavevr assembleSvr assembleOculusvr

But when I try to run noapix86 on an emulator by pressing the green play button in AndroidStudio I get the following error:

taskclusterBuild = true
//geckoViewLocal = /Users/rbarker/Downloads/geckoview-default-armeabi-v7a-64.0.20180921212116.aar
Generated versionCode: 22691351

WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;
WARNING: Cannot build selected target ABI: x86, no suitable splits configured: armeabi-v7a;

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Cannot build for ABI: x86 supported ABIs are: armeabi-v7a

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s

[bluemarvin]

@keianhzo Can you see if you can fix the play button? I tried poking at it but didn't see anything obvious.

[MortimerGoro]

I have the same problem

Tried to disable splits and update AS/plugins with no luck:

    splits {
        abi {
            enable false
        }
    }

[keianhzo]

Fixed the MacOS ABI filtering issue, should work fine in all platforms now.