Use undefined instead of null for the default Object3DComponent value

ecsyjs · Aug 6, 2020 · c87ee09 · c87ee09
1 parent 2a42dcb
commit c87ee09
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/core/Object3DComponent.d.ts b/src/core/Object3DComponent.d.ts
@@ -2,9 +2,9 @@ import { Component, RefPropType } from "ecsy";
 import { Object3D } from "three";
 
 export class Object3DComponent extends Component<Object3DComponent> {
-  value: Object3D | null;
+  value?: Object3D;
 
   static schema: {
-    value: { default: null, type: RefPropType<Object3D> }
+    value: { type: RefPropType<Object3D> }
   };
 }
diff --git a/src/core/Object3DComponent.js b/src/core/Object3DComponent.js
@@ -3,5 +3,5 @@ import { Component, Types } from "ecsy";
 export class Object3DComponent extends Component {}
 
 Object3DComponent.schema = {
-  value: { default: null, type: Types.Ref }
+  value: { type: Types.Ref }
 };
diff --git a/src/core/entity.d.ts b/src/core/entity.d.ts
@@ -9,5 +9,5 @@ export class ECSYThreeEntity extends _Entity {
   addObject3DComponent(obj: Object3D, parentEntity?: Entity): this
   removeObject3DComponent(unparent?: boolean): void
   remove(forceImmediate?: boolean): void
-  getObject3D<T extends Object3D>(): (T & ECSYThreeObject3D) | null
+  getObject3D?<T extends Object3D>(): T & ECSYThreeObject3D
 }