New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document Unity XR testing (fixes issue #155) #297
Conversation
docs/xr-testing.md
Outdated
![Animation of Unity's XR Settings](https://raw.githubusercontent.com/cvan/unity-webvr-export/docs-xr-testing/docs/images/unity-xr-settings.gif "Animation of Unity's XR Settings") | ||
|
||
1. Select the **`File > Build Settings…`** menu option from the top-level Unity application menu. | ||
2. When the pop-up window appears, select the **`PC, Mac & Linux Standalone`** option in the **`Platform`** list, and click the **`Switch Platform`** button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised you don't have to actually click the Switch Platform
button. you have to only highlight the PC, Mac & Linux Standalone
option in order for the Inspector > XR Settings
pane to show up. 👍
will remove the screenshot, regenerate the GIF, update this instruction (2), and remove the last instruction (8). that simplifies things a bit. sweet! 👍
50fd474
to
d7f2777
Compare
@caseyyee this is updated - can you take another review? you can view the rendered Markdown doc here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although, looking at the pictures I can see most of the interactions concentrate on the bottom-right corner but they are so big that you can get lost trying to identify what's happening.
Would it be possible to add some visual clues, like some arrows pointing to the relevant widgets, or a special highlight on the region which is more important, or a shade effect on the parts that are less important?
docs/xr-testing.md
Outdated
- **`OpenVR`** (i.e., for the HTC Vive and Windows Mixed Reality headsets) | ||
- **`Oculus`** (i.e., for the Oculus Rift and, soon, Oculus Go headsets) | ||
|
||
The VR devices are sorted in the order in which Unity tries to enable VR devices at runtime or during VR preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a reminder about "double checking the platform is still WebGL" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. I also second @delapuente's comment on making the screens clearer. Could probably just do partial screens of the menu's with pointers to the relevant bits. Can address this later though i feel. This is a good start!
docs/xr-testing.md
Outdated
@@ -0,0 +1,30 @@ | |||
# Testing your Unity project in Virtual Reality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe being a bit more specific will be good here? Something like:
"Enable Unity XR support for faster testing within Unity editor"
7a3f25e
to
7ef8ebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
b3ae4f3
to
07a575a
Compare
I've updated the screenshots and GIF. see the output of the latest version here. thanks for the great feedback, @delapuente and @caseyyee! |
(PNGs are compressed)