This repository has been archived by the owner on Apr 4, 2018. It is now read-only.
initial spec rewrite (v1.0) #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Begin presenting to the VRDisplay. Must be called in response to a user gesture. | ||
| * Repeat calls while already presenting will update the VRLayer being displayed. | ||
| */ | ||
| Promise<void> requestPresent(); |
There was a problem hiding this comment.
requestPresent Needs to accept a VRLayer
|
Looking good so far. Added a few comments from what I could remember earlier, I'll try and do a more thorough readthrough soon. |
|
Merging now so that I can make some updates against it. Sorry if you were still working on a few things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @toji @kearwood
Here's the initial draft. There are omissions and issues. I'll continue work on this, but don't hesitate to say something when you see something.