New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish typing support. #116
Finish typing support. #116
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1258 1290 +32
=========================================
+ Hits 1258 1290 +32
Continue to review full report at Codecov.
|
In a new fresh Python 3.6 venv on rev 238464c, there still are the following errors:
|
Yes, that's because of missing annotations for pytest fixtures when pytest isn't installed. Using tox or pre-commit will install pytest to avoid these errors. |
Yes, you're right! |
238464c
to
eeebfea
Compare
eeebfea
to
fd5d843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
This finishes the work by @nth10sd in #115 . Much of the nicer syntax depends on __future__ annotations which has other caveats, so I've backported this to 3.6 for now.
This also enables mypy in pre-commit, enables Python 3.10 CI, and enables lint across all Python versions in CI.
Supersedes #115.