Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18: --url localfile doesn't work on Windows. #19

Closed
wants to merge 1 commit into from

Conversation

jschwartzentruber
Copy link
Collaborator

After this change yields:

windows:
D ffpuppet [2017-09-07 14:55:24] sending response with redirect url: 'file:///C:/Users/user/Desktop/tc.html'
linux:
D ffpuppet [2017-09-07 15:01:45] sending response with redirect url: 'file:/home/user/Desktop/tc.html'

Both redirects work properly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.65% when pulling e583dc5 on truber-fix-windows-url-arg into a84915f on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.65% when pulling e583dc5 on truber-fix-windows-url-arg into a84915f on master.

@tysmith
Copy link
Collaborator

tysmith commented Sep 25, 2017

Thanks! I used the idea in this PR in commit ab8fc75.

@tysmith tysmith closed this Sep 25, 2017
@tysmith tysmith deleted the truber-fix-windows-url-arg branch October 31, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants