Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_to should be allowed to specify heterogenous pools #218

Open
jschwartzentruber opened this issue Nov 10, 2022 · 0 comments
Open

apply_to should be allowed to specify heterogenous pools #218

jschwartzentruber opened this issue Nov 10, 2022 · 0 comments

Comments

@jschwartzentruber
Copy link
Contributor

Currently we require most fields to be identical for the whole set of apply_to configs.

# while these fields are not required to be defined here, they must be the same
# for the entire set .. at least for now
same_fields = (
"cloud",
"cores_per_task",
"cpu",
"cycle_time",
"disk_size",
"gpu",
"imageset",
"metal",
"minimum_memory_per_core",
"platform",
"schedule_start",
)

This allows a shortcut later on where those values are set in the parent pool to be used by the decision somehow (according to the comment).

# set the field on self, so it can easily be used by decision
setattr(self, field, getattr(pools[0], field))

This shouldn't be necessary. It prevents us from creating a pool (eg. with macro COVERAGE=1) that applies to pools in disparate clouds or different OS'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant