Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(privacy): dynamically import Glean #72

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix(privacy): dynamically import Glean #72

merged 2 commits into from
Oct 25, 2023

Conversation

collectedmind
Copy link

This just sets up a dynamic client side import of the @mozilla/glean/web for privacy page.

@collectedmind collectedmind requested a review from a team as a code owner October 25, 2023 20:03
wtfluckey
wtfluckey approved these changes Oct 25, 2023
View reviewed changes
Copy link

@wtfluckey wtfluckey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it's working beautifully! thank you Joel!

giphy-8

@collectedmind collectedmind merged commit 001fffb into main Oct 25, 2023
3 checks passed
@collectedmind collectedmind deleted the fix/user-settings-glean-dynamic-glean branch October 25, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-liddle anthony-liddle anthony-liddle approved these changes

@wtfluckey wtfluckey wtfluckey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@collectedmind @anthony-liddle @wtfluckey