Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing with Yarn is awkward #21

Closed
IslandUsurper opened this issue Nov 26, 2018 · 0 comments · Fixed by #22
Closed

Installing with Yarn is awkward #21

IslandUsurper opened this issue Nov 26, 2018 · 0 comments · Fixed by #22

Comments

@IslandUsurper
Copy link
Contributor

In package.json:

"engines": {
    "node": "^4.1.0"
  }

This is equivalent to "node": ">=4.1.0 && <5.0.0". Most users, and I imagine even most Kibo tenants, aren't using Node 4.x any more. For npm, this doesn't matter much because the engines declaration is only a suggestion. However, yarn has a strict engines check by default. In order to install mozu-node-sdk, you have to pass --ignore-engines to the install command.

It would be better to have an accurate engines specification, possibly "node": ">=4.1.0".

IslandUsurper added a commit to IslandUsurper/mozu-node-sdk that referenced this issue Nov 26, 2018
Fixes Mozu#21.

Declare that the SDK works with all modern versions of Node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant