Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config object to FiddlerProxy plugin to be able to set Fiddler URL #12

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

aleksanderson
Copy link
Contributor

Provided changes to FiddlerProxy plugin might be helpful when using Fiddler not on the local machine. For example, developing on mac, you might want to use fiddler on the windows machine running inside a VM like VMWare Fusion or Parallels Desktop. (Telerik provided instructions on how to set up such workflow: http://goo.gl/pdgQBa).

Assuming the current PR the plugin call signature would be the following:

//default fiddler url, e.g http://127.0.0.1:8888
client.plugins = [FiddlerProxy()];

//custom fiddler url
client.plugins = [FiddlerProxy({ url: 'http://192.168.1.37:8888' })];

@zetlen zetlen merged commit c4d16e9 into Mozu:master Dec 10, 2015
zetlen added a commit that referenced this pull request Dec 10, 2015
Merges PR #12: configurable fiddler proxy URL
@zetlen
Copy link
Contributor

zetlen commented Dec 10, 2015

Thanks, @aleksanderson, for your patience and for the PR. I had to make some minor changes to get the new tests to pass and to make your new plugin API tolerate an existing config object with a missing URI, but otherwise the code is unmodified.

Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants