Travis build for QT 5 fails on build #98 after modularization

[Mr-Kumar-Abhishek]

Travis build for QT 5 fails on build #98.

Build error is specifically for QT 5:

In file included from about_app.h:3:0,

                 from about_app.cpp:1:

sub_win.h:4:19: fatal error: QWidget: No such file or directory

compilation terminated.

And.. others such as this which inherits sub_win class. However the build is clean for QT 4

Check here for the build log

Refer here as a starting point to find a solution on how to make it compatible for both QT 4 and QT 5 with modularization

[Mr-Kumar-Abhishek]

This is one of those times when somebody yells..

I don't care if it builds on your machine ! We are not shipping your machine !!

on the other hand , keeping meta-object compilers was probably a good idea 💭

[Mr-Kumar-Abhishek]

This is ready to be worked on 😃

[Mr-Kumar-Abhishek]

Okay, so working on it. Testing the builds on test branch..

[Mr-Kumar-Abhishek]

Nope, having meta-object compilers doesn't makes much of a difference in the build

Check the log for details..

[Mr-Kumar-Abhishek]

Well, I suppose I have look into it after this build , I wonder why commits aren't referred here...

[Mr-Kumar-Abhishek]

Alright, I seem to have missed this, hmm...

sudo apt-get install -qq g++ qt4-qmake libqt4-dev qt5-qmake qtbase5-dev" failed and exited with 100

well... now all my QT projects needs to be updated. 😒

[Mr-Kumar-Abhishek]

I suppose I was not much updated due other priorities. Travis CI was upgraded to container-based infrastructure. Refer to these docs for migrating

[Mr-Kumar-Abhishek]

Build logs could be compared by referring Travis build 103 and Travis build 97 which are for the same commits but in different times.

[Mr-Kumar-Abhishek]

Hmm...changes are not required much if any for migrating.. sudo works in Travis CI for installing Ubuntu packages.. however packages are changed so some options are not available such has
QT 4.8 doesn't have qmake -qt=qt4 option... check the build here

[Mr-Kumar-Abhishek]

packages qt5-qmake and qtbase5-dev are not available now... I so need to be in ubuntu system to resolve this quickly .. instead of pushing random commits for checking it.

$ sudo apt-get install -qq g++ qt5-qmake qtbase5-dev

E: Unable to locate package qt5-qmake

E: Unable to locate package qtbase5-dev

check this build here

[Mr-Kumar-Abhishek]

in between.. does these packages where white-listed after Travis CI was upgraded to container-based infrastructure ??

[Mr-Kumar-Abhishek]

Well, qtbase5-dev package isn't white-listed ..

[Mr-Kumar-Abhishek]

We will use beineri ppa which is white-listed. It gives tests and builds on different version of QT (more than the previous configuration)

[Mr-Kumar-Abhishek]

Got the Travis CI build 108 only the build of Qt 4.8 passed, others failed. Presumably we are back to main issue of making it compatible with Qt 5.x versions after modularization.

[Mr-Kumar-Abhishek]

The docs only gives way to transition from QT 4 .x to QT 5.x, however, it can't be made to be compatible on both with this modularization. So either we have to keep this modularization and be in Qt 4.x or remove most of the modularization and make it compatible for both Qt 4.x and Qt 5.x versions.

[Mr-Kumar-Abhishek]

It would be better to keep this in 4.x and leave transitioning from QT 4.x to QT 5.x in another issue on a later date. For, now just Travis CI configuration file needs to be adjusted so that it only builds for QT 4

[Mr-Kumar-Abhishek]

No error in builds now. Closing this issue.