Skip to content

Commit

Permalink
Quote $dotnetRoot argument to InstallDotNet invocation
Browse files Browse the repository at this point in the history
Failure to quote the argument leads to incorrect assignment of positional arguments if the working path contains spaces.

fixes dotnet#2435
  • Loading branch information
Mr-Tao committed Sep 5, 2021
1 parent bf414f0 commit 348ff0a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion eng/common/dotnet-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ if [[ $architecture != "" ]] && [[ $architecture != $buildarch ]]; then
dotnetRoot="$dotnetRoot/$architecture"
fi

InstallDotNet $dotnetRoot $version "$architecture" $runtime true $runtimeSourceFeed $runtimeSourceFeedKey || {
InstallDotNet "$dotnetRoot" $version "$architecture" $runtime true $runtimeSourceFeed $runtimeSourceFeedKey || {
local exit_code=$?
Write-PipelineTelemetryError -Category 'InitializeToolset' -Message "dotnet-install.sh failed (exit code '$exit_code')." >&2
ExitWithExitCode $exit_code
Expand Down

0 comments on commit 348ff0a

Please sign in to comment.