Storing advanced settings and some clean-up #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit stores the value of the advanced checkbox and text boxes in the registry similarly to other settings. It insures that on the next startup, the values will be persisted and users will not have to re-enter their desired Advanced mode values on every single app start.
Going forward, bumping up version will require a change to the `AssemblyInfo.cs` file, but it won't require changing the form/window title, as that is derived from the version there. For people trying to check the code, it will be more obvious where to look for the current version, as previously this was only exposed as the hardcoded form title.
After moving the handles to the designer / `InitializeComponent`, we need to ensure, that anything needed by the setting changed handlers is initialized too before loading and setting the checked states. For now this only applies to AutoBorderless - after setting Checked to true, it tries to start the process monitor, so `ProcessMonitor` must be initialized before that.
When minimized to tray, the right click context menu has an used Settings item. This removes it and instead adds a "Show Bordeless Minecraft" item that re-opens the main window
There is an used `checkBox3_CheckedChanged` method that refreshes the process list. I'm assuming the checkbox was similar to current "Show All Clients" settings. This removes the unused method and adds refreshing the list to the "Show All Clients" handler.
Previously auto borderless would always use default parameters for window position/size. This changes the behaviour to use the advanced mode parameters, if enabled.
Mr-Technician
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
goBorderlessButtoninstead ofbutton1