Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added indicators for processes not being found #30

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

Cryptizism
Copy link
Contributor

@Cryptizism Cryptizism commented Jan 17, 2022

What I did

Added an indicator for when processes haven't been found and notifies the user that they can show all clients if they are not doing so already

Proof of working

x7NZm1c6iY

For author to do

  • Update the version to what you find appropriate

Additional info

I had issues related to signing certificate in the certificate store when I tried running it with the debugger even before I edited any code. I deleted:

<PropertyGroup>
  <ManifestCertificateThumbprint>F0BB6B4AB81DCB530A46721FAE58938516286746</ManifestCertificateThumbprint>
</PropertyGroup>
<PropertyGroup>
    <ManifestKeyFile>BorderlessMinecraft_TemporaryKey.pfx</ManifestKeyFile>
</PropertyGroup>
<PropertyGroup>
    <GenerateManifests>true</GenerateManifests>
</PropertyGroup>
<PropertyGroup>
    <SignManifests>true</SignManifests>
</PropertyGroup>

However, I left it out of this pull request as I believe the error occurred at the fault of myself.

@Cryptizism Cryptizism marked this pull request as draft January 17, 2022 18:27
@Cryptizism Cryptizism marked this pull request as ready for review January 17, 2022 18:27
@Cryptizism Cryptizism marked this pull request as draft January 17, 2022 18:31
@Mr-Technician Mr-Technician marked this pull request as ready for review January 17, 2022 18:32
@Mr-Technician Mr-Technician merged commit 69fb1f4 into Mr-Technician:develop-1.0 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants