Waterfox Classic 2020.01 Causes github to no longer work. #1360
Comments
|
I can't even edit an issue no idea what's going on here. |
|
What Debian version? |
|
I've tried with safe mode and for some reason Github is not seeing it as a recent version. It's your build that I'm using and then getting the following. I did safe mode and no change. don't know where they're getting that info from. |
|
|
@133794m3r Very strange. What Debian version have you? |
|
I'm using the parrot fork that's basically debian-testing plus some random extra security features thrown in. I have no clue why it decided to do this after updating as before today it was AOK and github worked perfectly fine. |
|
I'm getting your package from the opensuse build service. And for some reason it's reporting(in it's HTTP POST parameter's useragent string) that it's firefox version 60. |
|
This has happened before... Check #784 and #785 and other issues. While that got rid of the banner, the page still didn't work properly. For example switching between What luckily fixed github for me was to use advice from this comment, to use User Agent switcher addon and override the User Agent to MS Edge browser. |
|
Same here on Windows. Overriding User Agent to Edge still doesn't fix everything, unfortunately. I can't reply to pull request review comments, for instance. One of the rare times I'm glad the actual Edge exists. |
|
As Github rolls out Custom Elements/Shadow Dom usage - browsers which do not have it end with broken layout elements. So, "Polymer WebComponents" have to be added to Waterfox Classic to make Github work flawlessly again, which is a rather insane task. |
|
For those of you who are having the issue, could you test with |
Set it to true and restarted the browser, for good measure. Doesn't seem to do the trick. |
|
Try setting both |
I did. Also, YouTube stops working with |
|
@don-reba Can you show output of browser's console (ctrl+shift+i) with disabled both prefs? PS: Seems that users of PaleMoon and Basilisk also have some problems with GitHub and it's related with Polymer WebComponents and Moonchild works on getting the Polymer WebComponents features. |
Just a bunch of CSS warnings. Nothing else. |
|
@hawkeye116477 They are working indeed on getting this on board, and some progress has been made. Would for sure go faster if more people would be willing to work on it and lending them a helping hand - as this also could be of benefit for Waterfox Classic users! |
|
It's a Github issue, they flipped the switch. Use |
That might cause trouble. Recall #784 (comment):
No problem with Waterfox Classic 2020.01 (20200110195245) in safe mode on Manjaro Linux. UA string, non-modified:
Take care to not throw in anything that might modify the UA string.
Try not overriding. It defeats the object of the whitelisting that GitHub made for Waterfox Classic. |
|
Cross reference https://redd.it/eq3rgs NB the sticky comment. From a screen recording of Waterfox Classic 2020.01 (20200110175929) on Windows 10 working with GitHub, no problem:
|
|
The default useragent for my stock waterfox build OpenSuses's build system is firefox60 waterfox isn't included. Don't know if it is a build issue or what because I had no addons that modified the user agent. |
Such as? I don't see anything related in the linked comment. |
@ACyphus wrote (in the linked comment):
Emphatically:
So, use of a UA that excludes In this context, troublesome UA strings include:
|
Please, can you be specific about any of the random stuff?
Given the working string (Alex's
– discovering why yours differs will be key to resolving this issue #1360. Please let us have troubleshooting information. Use the Copy text to clipboard button at:
Side note: you can make a block of One line above, one line below each block as described at https://guides.github.com/features/mastering-markdown/#examples ▶ Code
Thanks |
And here's proof that it's his build. |
|
Is the issue reproducible with a new profile?
Have you ever used Waterfox Current (or any other 68-based build of Waterfox) on the same computer? Please let us have troubleshooting information as described above, #1360 (comment) Thanks. |
|
@grahamperrin |
|
@133794m3r It's not build issue, default is |
|
I can create a new profile and it does change the useragent back to default. So what file would be in there? about:config doesn't show the useragent string being modified. So where would it be stored at. Apparently the profile's doing something. It's the same profile I've had since I first used firefox doing safe-mode doesn't change the user agent string only a new profile does. |
|
As discussed here, you can also workaround this either by the function removePjaxAttr() {
document.querySelectorAll('*').forEach(function(node) {
if (node.hasAttribute("data-pjax")) {
node.removeAttribute("data-pjax");
}
});
}
window.onload = removePjaxAttr;or via the
In the second case, you will also need to use the Scriptlet Doctor to bypass GitHub's strict content security policy. PS: Despite this note, both |
|
@JustOff : don't both approaches merely break CSP for github.com? The script line for uBO even begins with github.com, and the monkey script can also be exclusively made active for only github.com. So what's the big deal? As a worst case scenario, someone potentially phishing one's github login PW - or am I missing something? |
|
@ltguillaume the reload-thingy is just a minor annoyance. But have you tried to edit your last comment here? Or toggling the preview on a new comment in this thread? It works until a certain threshhold is reached, then it stops. This, and sometimes pages loading eternally are the only real issues I have with classic on Github. Not having a preview can be worked around by copy-pasting it into a "new issue" which one never submits. But not being able to edit a post can be embarassing at times 😉 |
|
@IzzySoft : does any of the two work-arounds JustOff mentions solve all/ some/ none of the issues you experience? |
|
@LeeBinder I didn't understand which issues they should address (and what side-effects to expect), hence I didn't try either yet. And please don't ask me why right now the preview works again (while it didn't on my previous comment) – the only difference is that this time Waterfox warned me about a script slowing down the page and asked whether to abort it (which I did). This suggests some "after-loading Ajax", so it might be worth trying one of those approaches. I've just installed that UserScript now, let's see… Nope. I've picked another issue with 30+ comments, not even username completion is working with the script enabled (or disabled), preview neither. So no difference I can see. With or without the UserScript, console ends with |
I can edit my comments just fine. I also tried toggling between Preview and Edit 20 times, while changing something every time: no issues. |
|
@ltguillaume This happens randomly, apparently they are doing some tests. |
|
This really needs fixing if WF is to remain relevant. More sites are steadily becoming unusable. Yahoo mail is another which has affected me recently. I don't understand what the point of the Current release is if it doesn't support the classic add-ons, since that IS the point if WF. If we wanted that we'd just use FF or another browser. There's no information at all on the site as to what changes beyond the very brief and inadequate description on the download page. Are any of the classic add-ons supported? Where can we find out? Changing the referrer doesn't work here, either, Neither blocking or nor sending the FF ID as suggested above make preview or the comment box menu work. I had to use Chrome to be able to do anything at all here other than read. Thanks. |
|
@Cryo99 Maybe it'll find some other edge. |
|
I am indeed sticking with Waterfox Classic. As for this issue, I forgot to report that |
Brilliant! Thanks. That works for me, too. |
|
I thought I'd chime in to say that setting dom.webcomponents.enabled to true seems to fix github for me. Hopefully it doesn't break any other sites. However I'm forced to agree with the sentiments of @Cryo99 : This needs to be resolved for waterfox to remain a viable browser long-term. I'm finding more and more broken sites every day. 100% of the reason why I use waterfox is for the "classic" addons, so from what I can tell using current is not an option (and seems pointless to me). Why would i use waterfox current instead of brave, or opera, or chrome, or firefox? |
Because it's no spyware. You're not honestly comparing that with Chrome, are you? 😆 Apart from that I agree: were it not for the classic addons, I'd have switched to Current long ago. I found replacements for most, but not for all (for some it seems to be impossible to get their functionality with WebExts). Due to some other experiments, I now had enabled |
|
Oh, sorry: when I say "chrome", I actually mean "chromium". That's a thing that I have a habit of doing when communicating with people because most people reply with "What's chromium"? I'd never use actual chrome in a million years. Yeah, webextensions are less capable than xul, so some of the old addons cannot be reimplemented on webextensions. That's the whole point of waterfox for me. |
|
Surely, the vast majority of people who care about privacy but not xul extensions will use Brave. |
|
@don-reba yeah, that's what I'll be switching to if waterfox classic becomes untenable and current doesn't support xul. |
It can break some sites, but not many sites uses webcomponents, so maybe that's why you didn't notice. As a alternative there is also Polly extension, which can inject webcomponents polyfill to sites and doesn't break other sites. |
Polly just crashes the entire browser (not just a tab) when trying to do some things. |
|
@Squall-Leonhart I don't have that problem. |
|
Everyone gets it under the same conditions / sites used / site features https://www.reddit.com/r/waterfox/comments/jbql07/github_no_longer_works_with_waterfox_classic/ in githubs case, its triggered by top left search. |
I can't reproduce that. I checked on both Manjaro Linux and W10. Anyway you can report that at https://github.com/zakius/Polly/issues. |
|
@hawkeye116477 I've been using Polly a long time (since I announced it above). Still had to Ctrl-Shift-r every 3rd or 4th time here at Github. A couple of days ago I've enabled webcomponents directly. No force-reload needed since. Thinking about removing Polly again now and sticking with the "master switch". |
@Squall-Leonhart In general, never ever claim "Everyone", please!: I can NOT reproduce that in latest WF Classic 2020.10 macOS, neither with current Polly 1.4 nor with previous Polly 1.3, regardless if Polly only with I kindly request you to edit your generalizing statement into what should reflect reality better, which would be "Some people report they get...". Thank you. Would you also please provide your OS + version? |
|
this might be a Windows only issue: https://github.com/zakius/Polly/issues/12#issuecomment-735401277 |
|
I only talk about operating systems that matter, mac users don't. |
👎 with that childish/ non-adult attitude you are not getting any more support here, bro. You just shot yourself into your own foot. Happy screaming, buddy |
|
I honestly thought github was above shitposting. I still can't believe I saw such childish behavior on here. Also since I've force enabled the config option I've yet to have an issue except with the EdX main site but that's on them apparently. |
|
I had problems on github with Solved with this: |
|
The Polly repository is now empty. |
|
@enricodias latest Polly v.1.9 is stored here (direct download link) |
and others
Describe the bug
Github doesn't work anymore after updating to latest stable release.
When first visiting the site it gives you the message "Old versions of firefox aren't supported please upgrade" message for some reason like it used to when I was using PaleMoon way back when their useragent was still spoofing an outdated firefox version.
To Reproduce
Expected behavior
The site to work the way it did before I updated to 2020.01. When I was on 2019.12 it worked AOK so I don't know what's going on.
Screenshots
file:///home/macarthur/Desktop/tmpdownload/Screenshot%20at%202020-01-15%2013-15-43.png
file:///home/macarthur/Desktop/tmpdownload/Screenshot%20at%202020-01-15%2013-15-53.png
My configuration
Additional context
Saw there was an update, updated it. Now the site's borked. Can't even upload attachments to this issue.
The text was updated successfully, but these errors were encountered: