-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdNauseam, Findx Privacy Control, Ghostery, HTTPS Everywhere, Nano Adblocker, Privacy Badger and uBlock Origin are bugged by single-process Waterfox #580
Comments
Only FreeBSD package? Can you bisect downstream commits down, starting with Firefox 56.0.2? Among ~250 patches in 56.1.0 I may have accidentally backported something that wasn't compatible. Alternatively, try building Waterfox outside of ports:
|
If it helps to diagnose the issue:
For example, after showing Diigo Toolbar:
NotesPartly crossing paths with initial responses …
No. The reproduction with 56.1.0 was on a Mac. I can easily get earlier Opening post steps to reproduce are clean and reproducible. I have not attempted to reproduce the blankness symptom (the screenshot in this comment) with anything other than my non-clean 'everyday' profile on FreeBSD-CURRENT. |
Late night afterthoughtsA
Without looking at any console, I guess it's simply symptomatic of there being no content. BMeta, tracking: #538 |
Maybe worth notingIt's not enough to disable uBlock Origin for e.g. Twitter; the issue will persist until uBlock Origin is entirely disabled. A brief comparison with Firefox
ResultNot reproducible. |
For Firefox with e10s disabled, https://bugzilla.mozilla.org/show_bug.cgi?id=1348497#c38 (2018-01-03) was RESOLVED INVALID:
I don't intend to test with the extensions or scenarios that featured in Mozilla bug 1348497. Instead, the brief comparison with Firefox (above) raises hope that there is a commit (or set of commits) – somewhere between what we already have with Waterfox, and what's for Firefox 60.0.1,1 – that will allow reliable use of extensions such as uBlock Origin with a future single-process Waterfox. I'll test Findx Privacy Control and Privacy Badger with single-process Firefox 60.0.1,1 … |
@NoEscape hi, your nickname is familiar (I can't recall why) and this part of your
https://www.mozilla.org/firefox/56.0.4/releasenotes/ is (as expected) 404 not found and Waterfox 56.0.4 is outdated but existent … at first I guessed that you had used Waterfox 56.0.4 but then I saw the 32-bit OS so that's a bad guess. In any case … Single-process Firefox Quantum
Single-process is edge case for Firefox Quantum but I'll be interested in your finding. Here,
|
@ghostwords hi, tl;dr I wonder whether you can help us to identify a Mozilla commit that can be ported to Waterfox 56.x to fix this Waterfox issue, which affects Privacy Badger (and Findx Privacy Control and uBlock Origin). Additional informationVarious site breakages (Wordpress Admin, eBay) in Firefox · Issue #1295 · EFForg/privacybadger:
Mozilla bug 1373776 was RESOLVED WONTFIX. Privacy Badger issue 1438 was closed following an affirmative comment from @arthurlogilab re:
Privacy Badger issue 1438 began with @adimascio giving the https://www.logilab.org/ example. Here now with single-process Waterfox 56.2.0.31_3 on FreeBSD-CURRENT:
– as originally described by @adimascio,
With Privacy Badger disabled, sites such as Twitter and Logilab.org do work. |
Sorry, I don't have any additional insight beyond what I wrote in https://bugzilla.mozilla.org/show_bug.cgi?id=1373776#c18 |
@ghostwords thanks for the speedy reply and pointer. @br-privacore hi, re: the tl;dr at #580 (comment) above I wonder whether you, too, might help to identify a Mozilla commit. With Findx Privacy Control enabled, https://www.logilab.org/ and Twitter are troublesome. With the extension disabled, the trouble ceases. The Twitter and Logilab.org cases are not reproducible (for me) with Firefox 60.0.2 in single-process mode, so I assume that a commit was made somewhere between Firefox 56.0.2 (upon which Waterfox 56.0 was based) and Firefox 60. |
@grahamperrin : Findx Privacy Control is based on uBlock Origin. I'm not sure how we can help, as we only test against the few latest releases of each supported browser. Only thing I can think of is to try every Firefox release between 56 and 60 (https://ftp.mozilla.org/pub/firefox/releases/) and see when the bug disappears, to narrow down the number of patches to investigate. Did you have anything else in mind? |
@br-privacore thanks. I'll go for 57, 58 and 59 on a Mac; the
Only the possibility of someone already knowing either (a) the release point at which the bug disappeared; or (b) ideally, the relevant commit(s). I'll follow up. |
Towards identifying the fixTesting a Firefox profile with
https://ftp.mozilla.org/pub/firefox/releases/58.0b3/ includes files modified on 2017-11-14. https://wiki.mozilla.org/Releases/Firefox_58/Test_Plan https://wiki.mozilla.org/Releases/Firefox_58/Test_Plan#Beta_3 refers to:
From https://wiki.mozilla.org/Releases/Firefox_58/Test_Plan/Beta/3#Bug_fix_verification:
|
Beta 3 usually marks the end of Nightly phase for a given milestone. Try using mozregression to bisect every build of Nightly 58 phase: from 2017-09-28 to 2017-11-14. |
OK, I knew this wouldn't work, but I had to try it:
:-) so I reckon, it's time for me to wipe the internal HDD on a nearby MacBookPro8,2 and Boot Camp it with Sierra and a 64-bit Windows (10, if the 2011 Mac hardware will take it). (I could continue with the Sierra that's currently used, but it's on an external HDD and I suspect that USB 2.0 will make things such as mozregression feel unreasonably slow.) |
Also bugged:
– maybe no longer available from addons.mozilla.org but it's mentioned at https://www.reddit.com/comments/8oyy68/-/e07cmvt/?context=2 and does cause e.g. https://www.logilab.org/ to not work with single-process Waterfox 56.2.0.31_5. mozregressionI haven't found time yet, sorry. (Catching up on sleep; Boot Camp Assistant on the MacBookPro8,2 is limited to Windows 7 (no go with a Microsoft |
Below,
|
@grahamperrin, try specifying an earlier start date ( |
In other words, you need to find a date of Nightly build that's affected by the issue at hand. mozregression cannot bisect the range if both of the ends are good or both are bad. |
2018-06-14T18 bisection log.txt From the log:
I did look at 1396395 a few days ago but I imagined that it was unrelated, because with the given steps to reproduce:
– I could not produce a crash in Waterfox 56.2.0. The changesets:
|
Thanks. Can you try Waterfox 56.2.0.53 on FreeBSD? It already includes #623. FWIW, bisecting on FreeBSD amounts to building each step from source while applying bustage fixes. Due to time-consuming nature of babysitting build to check for bustage I rarely do it outside of critical issues. And for anyone else the process requires experience with Firefox development workflow. |
@jbeich big thanks. If I don't receive a response to #623 (comment) tomorrow I'll close this issue 580 as fixed (subject to merge of the PR). @Hainish hi, FYI HTTPS Everywhere is also amongst the products that are bugged by single-process. |
@grahamperrin, unnecessary. When #623 is merged this issue would be automatically closed. Try hovering mouse pointer over |
@jbeich you're right. I shouldn't encourage premature closure … just, I sort of wanted one more thing to appear ☑ or closed above and below the line at #538 (comment) |
Observations, steps
Single-process. With any of these enabled:
– some types of navigation, from one URL to another, are bugged.
Most noticeable with Twitter, for example:
Expected
– in the title bar (if a title is allowed there); in the tab; and in (e.g.) the Task Manager of KDE
Actual result
twitter.com/waterfoxproject
in the tabWorkaround
– or reload.
Thoughts
For around a week (beginning ~2018-05-16) I imagined that the issue arose around the time of testing then releasing Waterfox 56.2.0. This evening I proved myself wrong by quickly reproducing the issue with 56.1.0.
It's possible that all three extensions share the same bugged code, however this issue does feel regressive to me.
Not comparably bugged
Disconnect 5.18.21
Malwarebytes Browser Extension BETA 1.0.21
The text was updated successfully, but these errors were encountered: