Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV_BASIC skill failure should not trigger default animation #387

Open
kontownik opened this issue Apr 17, 2024 · 0 comments
Open

NV_BASIC skill failure should not trigger default animation #387

kontownik opened this issue Apr 17, 2024 · 0 comments
Labels
Bug Something that is already regarded as completed not working how it should be.

Comments

@kontownik
Copy link

kontownik commented Apr 17, 2024

Steps to reproduce:

  • Create new Novice 1/1
  • Type any emote e.g. "/ok"
  • Server returns error because your skill level is too low
  • Skill.js onSkillResult() it's triggered

Actual result:
As every failure in this function it's triggering the default animation. While "Basic skill" it's passive.

Expected result:
should not trigger SkillAction['DEFAULT'] animation.

Additional context
Probably there could be more skills like that, but I don't remember easy way to find all the passive skills to compare.

I was thinking about solution like this: master...kontownik:roBrowserLegacy:fix/basic_skill_failure
but I need to hardcode line breaks to match current ones I believe

@kontownik kontownik added the Bug Something that is already regarded as completed not working how it should be. label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that is already regarded as completed not working how it should be.
Projects
None yet
Development

No branches or pull requests

1 participant