Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smog warning type for Environment Canada #200

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

jbytheway
Copy link
Contributor

There is currently a Smog Warning being issued by Environment Canada, which is not supported by the card.

This change adds support for this warning.

Here's the error I was getting before this change:
error-screenshot

Here's what it looks like after this change:
after-edit-screenshot

This works for English, but I was unable to figure out how to test it for French (there doesn't seem to be a language setting for the Environment Canada integration?).

The title of the French warning on the website is "Avertissement de smog en vigueur pour" so I'm guessing the warning would be "Avertissement De Smog" and this set the French to just "Smog" too, but that's just a guess.

There is currently a Smog Warning being issued by Environment Canada,
which is not currently supported by the card.

This change adds support for this warning.
@MrBartusek
Copy link
Owner

MrBartusek commented Jul 1, 2023

This works for English, but I was unable to figure out how to test it for French (there doesn't seem to be a language setting for the Environment Canada integration?).

The title of the French warning on the website is "Avertissement de smog en vigueur pour" so I'm guessing the warning would be "Avertissement De Smog" and this set the French to just "Smog" too, but that's just a guess.

When configuring integration you can choose the coordinates and language. You can set up another exacly the same sensor but for French and test it that way

@jbytheway
Copy link
Contributor Author

Looks like I missed the chance to do that this time, since the warning is over. I'll keep an eye out for a future warning where I can check the French version.

@jbytheway
Copy link
Contributor Author

OK, smog warning returned and I tested the French. I guessed right that the French was "Avertissement De Smog". It works as expected.

Before:
french-smog-warning-before
After:
french-smog-warning-after

@MrBartusek
Copy link
Owner

OK, smog warning returned and I tested the French. I guessed right that the French was "Avertissement De Smog". It works as expected.

You did not push anything?

@jbytheway
Copy link
Contributor Author

You did not push anything?

Indeed. My previous guess was correct so I had already pushed the correct code for the French version. This was just confirming that it worked.

Copy link
Owner

@MrBartusek MrBartusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MrBartusek MrBartusek merged commit 4930ec8 into MrBartusek:master Jul 22, 2023
6 checks passed
@jbytheway jbytheway deleted the add-env-canada-smog-warning branch July 22, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants