Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update German translation #60

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Update German translation #60

merged 1 commit into from
Nov 18, 2021

Conversation

RubenKelevra
Copy link
Contributor

No description provided.

MrBartusek
MrBartusek reviewed Nov 18, 2021
View reviewed changes
Copy link
Owner

@MrBartusek MrBartusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the pr! German translation still misses common.unavailable keys, could you update them too?

@MrBartusek MrBartusek added enhancement New feature or request translation This PR modify translation files labels Nov 18, 2021
@RubenKelevra RubenKelevra marked this pull request as draft November 18, 2021 13:17
@RubenKelevra RubenKelevra changed the title [translation] de: hide_when_no_warning text [translation] de: optimize translation; add missing strings Nov 18, 2021
@RubenKelevra RubenKelevra marked this pull request as ready for review November 18, 2021 13:22
@MrBartusek
Copy link
Owner

Hey @jpbede @nurtext mind taking a look at this PR since you are German translation contributors?

@nurtext
Copy link
Contributor

nurtext commented Nov 18, 2021

@MrBartusek Looks good to me.

@jpbede
Copy link
Contributor

jpbede commented Nov 18, 2021

@MrBartusek LGTM 👍

@MrBartusek
Copy link
Owner

Thank you all!

@MrBartusek MrBartusek changed the title [translation] de: optimize translation; add missing strings Update German translation Nov 18, 2021
@MrBartusek MrBartusek merged commit bd532a7 into MrBartusek:master Nov 18, 2021
@RubenKelevra RubenKelevra deleted the patch-1 branch November 18, 2021 17:07
@MrBartusek MrBartusek mentioned this pull request Dec 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBartusek MrBartusek MrBartusek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request translation This PR modify translation files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RubenKelevra @MrBartusek @nurtext @jpbede