Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explosion of already_processed #109

Merged
merged 1 commit into from
Dec 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions django_vite/core/asset_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -449,23 +449,22 @@ def _generate_css_files_of_asset(
tags -- List of CSS tags.
already_processed -- List of already processed css paths
"""
already_processed = already_processed or []
if already_processed is None:
already_processed = []
tags: List[Tag] = []
manifest_entry = self.manifest.get(path)

for import_path in manifest_entry.imports:
new_tags, new_already_processed = self._generate_css_files_of_asset(
new_tags, _ = self._generate_css_files_of_asset(
import_path, already_processed, tag_generator
)
tags.extend(new_tags)
already_processed.extend(new_already_processed)

for css_path in manifest_entry.css:
if css_path not in already_processed:
url = self._get_production_server_url(css_path)
tags.append(tag_generator(url))

already_processed.append(css_path)
already_processed.append(css_path)

return self.GeneratedCssFilesOutput(tags, already_processed)

Expand Down