Add support for "smart" link routing

[dmitrygalperin]

Are there any plans to implement a "smart" link routing prop, where instead of taking the shortest path between two ports, links will avoid collision with other nodes to give the chart a neater appearance? Example attached

[MrBlenny]

I'm unlikely to have time to work on such a feature. Certainly not for at least a few months. Happy to accept PRs :)

[dmitrygalperin]

@MrBlenny Thanks, I'll see if I can put together a PR.

[dmitrygalperin]

I have a fork at https://github.com/dmitrygalperin/react-flow-chart/tree/master that implements this via config={{ smartRouting: true }}

If anyone would like to take a look or offer suggestions/concerns before I submit a PR, please feel free.

Some concerns:

Pathfinding is expensive so performance is slower. I am limiting pathfinding to only nodes that are in view as well as scaling down the resolution of the pathfinding matrix. As a fallback to when a path cannot be found, I create a direct right angle link between the ports.

I also feel that the pathfinding can be tweaked to make the paths neater, though I'm not sure exactly how, especially with performance in mind.

[MrBlenny]

@dmitrygalperin is that ready to be a PR?

[Pagebakers]

@dmitrygalperin @MrBlenny Any news? Would really like this to be merged!

[Pagebakers]

I just merged this in to my project, but I don't see any difference with smartRouting enabled. @dmitrygalperin is this the latest version you shared?

It's working quite well actually :)

[mchaledg19]

config={{ smartRouting: true }} doesn't work on my project. Any news for smart link?
<FlowChart chart={chart} callbacks={stateActions} config={{ smartRouting: true, // disabledPorts: [], validateLink: ({ linkId, fromNodeId, fromPortId, toNodeId, toPortId, chart }) => { if (chart.nodes[fromNodeId].type === chart.nodes[toNodeId].type) return false; return true; } }} Components={{ CanvasOuter: CanvasOuterCustom, NodeInner: NodeInnerCustom, Port: PortCustom, Link: props => <LinkCustom {...props} stateActions={stateActions} /> }} />

[Pagebakers]

The problem has probably to do with your custom port/link components. Remove those and it should work :)

[dmitrygalperin]

@MrBlenny @Pagebakers

Apologies, I'm just now getting time to get back to this. I think it's ready for a PR

[mchaledg19]

any update? if this is already merged?
@MrBlenny

[hyusetiawan]

@MrBlenny ping, would love to get the smart routing merged :)

[MrBlenny]

Yep, planning on getting to this over the coming weekend.

…

On Wed, 26 Feb 2020, 19:24 wahyu, ***@***.***> wrote: @MrBlenny <https://github.com/MrBlenny> ping, would love to get the smart routing merged :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#54?email_source=notifications&email_token=ACJ4QOGAEHKDAYYB6T5BY5LREYRKXA5CNFSM4JBQ6AZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM7IGQA#issuecomment-591299392>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJ4QOGECC6FOJOXFHSEGADREYRKXANCNFSM4JBQ6AZQ> .