Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom #125

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Add zoom #125

merged 3 commits into from
Apr 26, 2020

Conversation

ielijose
Copy link

@ielijose ielijose commented Apr 18, 2020

@ielijose ielijose changed the title Add canvas zoom Add zoom Apr 18, 2020
@x225501
Copy link

x225501 commented Apr 22, 2020

Really interested to see the zoom capability.

But prettier and docs and some build files buried the zoom feature code. All in one commit is making it really hard to read.

@ielijose
Copy link
Author

Really interested to see the zoom capability.

But prettier and docs and some build files buried the zoom feature code. All in one commit is making it really hard to read.

Hi, thanks for the feedback, I'll fix that.

@ielijose ielijose force-pushed the feature/add-canvas-zoom branch 13 times, most recently from 1cf2505 to a8648f8 Compare April 22, 2020 21:19
@ielijose
Copy link
Author

@nandurnair can you review now?

Thank you

@hayaah
Copy link

hayaah commented Apr 22, 2020

Hi @ielijose, I have been looking for a similar feature and was happy to see it being developed
but there is a bug in it, its caused by react-zoom-pan-pinch
please check attached link
attachment

@MrBlenny MrBlenny merged commit 9cc0b16 into MrBlenny:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants