feature/show-arrow-heads #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidanitoiu
commented
May 21, 2020
•
davidanitoiu
commented
- Added showArrowHead as a config option
- Created an ArrowHead link variant
- moved directional calculations to their own method and exported it to be used in the ArrowHead link variant
- fix Implementation for Arrow heads on links #97
|
@MrBlenny hi David. Thanks for the awesome project, this has been really helpful in my app. |
|
You should include the linkColor in the id of the marker def, otherwise having multiple link colors defined via properties won't have an effect on the arrow head. (I am not an SVG expert, but I think defs are cached based on id.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.