Fix: Node size not updated when node size changed on DOM #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el.offsetWidth and el.offsetHeight should be checked against node.size.width and node.size.height (which comes from chartData) rather then size.width and size.height (which is the local state). size.width and size.height is set by ResizeObserver, which will always be equal with el.offsetWidth and el.offsetHeight at this place, while this side effect being triggered by ResizeObserver.
zetavg
force-pushed
the
fix-node-size-change
branch
from
83afbac
to
353b1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
el.offsetWidthandel.offsetHeightshould be checked againstnode.size.widthandnode.size.height(which comes fromchartData) rather thensize.width and size.height(which is the local state).size.widthandsize.heightis set byResizeObserver, which will always be equal withel.offsetWidthandel.offsetHeightat this place, while this side effect being triggered byResizeObserver.