fix: keep data consistent w/ or w/o snapToGrid enabled #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the data integrity when
snapToGrid
option is not passed. If we do not explicitly store onlyx
andy
values, browser passes some extra information such asdeltaX
,deltaY
andnode
. Wherenode
inserts a full property list of an element that is being interacted with. This creates a huge performance problem whether it is kept in internal state or external.In my case I pass
chart
to a redux state, and this creates circular references, and it crashes the redux devtools.This is also mentioned in #58.