Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep data consistent w/ or w/o snapToGrid enabled #72

Merged
merged 1 commit into from
Jan 18, 2020
Merged

fix: keep data consistent w/ or w/o snapToGrid enabled #72

merged 1 commit into from
Jan 18, 2020

Conversation

sinan
Copy link

@sinan sinan commented Dec 30, 2019

This fixes the data integrity when snapToGrid option is not passed. If we do not explicitly store only x and y values, browser passes some extra information such as deltaX, deltaY and node. Where node inserts a full property list of an element that is being interacted with. This creates a huge performance problem whether it is kept in internal state or external.

In my case I pass chart to a redux state, and this creates circular references, and it crashes the redux devtools.

This is also mentioned in #58.

@MrBlenny MrBlenny merged commit 109245e into MrBlenny:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants