Allow clearing and disabling of history #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanGrahn
changed the title
|
@EthanGrahn - Thank you. That looks like some great changes. |
- make it a simple icon button - using trash icon - remove opacity for right-header-action
- fix issue with the display of the clear history button on the Favorites page - button was still visible when switching from History to Favorites - Header action for the Favorites page explicitly set to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a button on the history page that will clear current history. Added an option in the settings menu to disable history tracking. I also updated the user preference toggling to use the new window API used elsewhere. @MrChuckomo I am not good with the design portion of this, so would you be willing to edit the style for the clear history button? I only have a placeholder in currently.
Closes #53