chore: remove old metrics, reclaim drop indices first (#60)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
MrCroxx · Jul 10, 2023 · 296c51d · 296c51d
1 parent e502b30
commit 296c51d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 115 deletions.
diff --git a/foyer-storage/src/reclaimer.rs b/foyer-storage/src/reclaimer.rs
@@ -188,7 +188,10 @@ where
 
         let region = self.region_manager.region(&task.region_id);
 
-        // keep region totally exclusive while reclamation
+        // step 1: drop indices
+        let _indices = self.indices.take_region(&task.region_id);
+
+        // after drop indices and acquire exclusive lock, no writers or readers are supposed to access the region
         let guard = region.exclusive(false, false, false).await;
 
         tracing::trace!(
@@ -199,9 +202,6 @@ where
             guard.physical_readers()
         );
 
-        // step 1: drop indices
-        let _indices = self.indices.take_region(&task.region_id);
-
         // step 2: do reinsertion
         // TODO(MrCroxx): do reinsertion
 

diff --git a/foyer/src/lib.rs b/foyer/src/lib.rs
@@ -15,8 +15,6 @@
 #![feature(trait_alias)]
 #![feature(pattern)]
 
-mod metrics;
-
 pub trait Weight {
     fn weight(&self) -> usize;
 }

diff --git a/foyer/src/metrics.rs b/foyer/src/metrics.rs