refactor: simplify pointer trait and remove DefaultPointerOps #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 67.60% 67.29% -0.32%
==========================================
Files 41 41
Lines 5091 5014 -77
==========================================
- Hits 3442 3374 -68
+ Misses 1649 1640 -9
|
MrCroxx
reviewed
Aug 2, 2023
foyer-intrusive/src/eviction/mod.rs
Outdated
| use std::fmt::Debug; | ||
|
|
||
| pub trait Config = Send + Sync + 'static + Debug + Clone; | ||
|
|
||
| pub trait EvictionPolicy: Send + Sync + 'static { | ||
| type Adapter: Adapter; |
There was a problem hiding this comment.
It feels a little not unified here compared with other intrusive collections. Can we still use Adapter here?
MrCroxx
approved these changes
Aug 3, 2023
MrCroxx
pushed a commit
that referenced
this pull request
Apr 17, 2024
* refactor: simplify some generic type definition * refactor: simplify pointer trait and remove DefaultPointerOps * run clippy * fix test compile * rename PointerOps to Pointer * use adapter in eviction policy associated type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As titled.
Checklist
make checkandmake testin my local envirorment.Related issues or PRs (optional)