Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support insert if not exists async #212

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Nov 13, 2023

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As titled.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have passed make check and make test or make all in my local envirorment.

Related issues or PRs (optional)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the feature New feature or request label Nov 13, 2023
@MrCroxx MrCroxx self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #212 (78e25d4) into main (4c32fe1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 78e25d4 differs from pull request most recent head b97e9d8. Consider uploading reports for the commit b97e9d8 to get more accurate results

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   77.47%   77.44%   -0.03%     
==========================================
  Files          50       50              
  Lines        5815     5817       +2     
==========================================
  Hits         4505     4505              
- Misses       1310     1312       +2     
Files Coverage Δ
foyer-storage/src/storage.rs 1.19% <0.00%> (-0.03%) ⬇️

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx enabled auto-merge (squash) November 13, 2023 08:07
@MrCroxx MrCroxx merged commit ce2e222 into main Nov 13, 2023
8 checks passed
@MrCroxx MrCroxx deleted the xx/insert-if-not-exists-async branch November 13, 2023 08:07
MrCroxx added a commit that referenced this pull request Apr 17, 2024
* feat: support insert if not exists async

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

* chore: refactor async api impl

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

---------

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant