Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: impl Clone for config for simplification #293

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Mar 13, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the chore label Mar 13, 2024
@MrCroxx MrCroxx self-assigned this Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.11%. Comparing base (bd3fc1a) to head (899fc01).

Files Patch % Lines
foyer-memory/src/eviction/lru.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   77.11%   77.11%           
=======================================
  Files          61       61           
  Lines        7478     7478           
=======================================
  Hits         5767     5767           
  Misses       1711     1711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit 4db04a2 into main Mar 14, 2024
12 checks passed
@MrCroxx MrCroxx deleted the xx/clone branch March 14, 2024 02:55
MrCroxx added a commit that referenced this pull request Apr 17, 2024
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant