feat: add eviction alg hit ratio bench #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCroxx
reviewed
Mar 29, 2024
|
BTW, I've approved the Github Action. You can run CI and check the results now. |
The enum cache is more easy to use since it only has two generic parameters. The generic cache is more like an internal interface. Signed-off-by: xiaguan <751080330@qq.com>
Signed-off-by: xiaguan <751080330@qq.com>
|
All test fixed. |
|
Hi, you can run |
|
And if hakari check failed on CI, just remove the local Cargo.lock file and run make fast locally again. |
Signed-off-by: xiaguan <751080330@qq.com>
Thanks , it works. |
Agreed. Currently PR message covers some instructions except the hakari part. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 77.11% 77.10% -0.02%
==========================================
Files 61 61
Lines 7478 7478
==========================================
- Hits 5767 5766 -1
- Misses 1711 1712 +1 ☔ View full report in Codecov by Sentry. |
MrCroxx
pushed a commit
that referenced
this pull request
Apr 17, 2024
* feat: add eviction alg hit ratio bench * refactor: use enum cache instead of generic cache The enum cache is more easy to use since it only has two generic parameters. The generic cache is more like an internal interface. Signed-off-by: xiaguan <751080330@qq.com> * chore : sort foyer_memory's dependencies Signed-off-by: xiaguan <751080330@qq.com> * chore: use hakari to gen better dependencies Signed-off-by: xiaguan <751080330@qq.com> --------- Signed-off-by: xiaguan <751080330@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
insipred by https://github.com/cloudflare/pingora/blob/main/tinyufo/benches/bench_hit_ratio.rs
In order to implement new eviction algorithms later, such as s3fifo, we need an intuitive test to demonstrate how these algorithms work.
I also plan to test their performance under real trace datasets later (Tencent Photo Cache, Twitter Cache Trace). Should I include CSV files of around 200KB in the repository?
Checklist
make all(ormake fastinstead if the old tests are not modified) in my local environment.Related issues or PRs (optional)