Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove in-memory cache listener, advancve disk cache insert #463

Merged
merged 1 commit into from
May 10, 2024

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented May 10, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

This PR is a prerequisite of replacing the foyer-storage engine.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #462

@MrCroxx MrCroxx self-assigned this May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.59%. Comparing base (baebadb) to head (7011a15).

Files Patch % Lines
foyer/src/hybrid.rs 64.70% 6 Missing ⚠️
foyer-memory/src/cache.rs 88.23% 2 Missing ⚠️
foyer-memory/src/generic.rs 90.90% 1 Missing ⚠️
foyer-storage/src/large/generic.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   81.71%   81.59%   -0.12%     
==========================================
  Files          75       74       -1     
  Lines        9450     9380      -70     
==========================================
- Hits         7722     7654      -68     
+ Misses       1728     1726       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit 03f205c into main May 10, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/rlistener branch May 10, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: write disk cache when insert instead of waiting for eviction
1 participant