Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce prometheus metrics #54

Merged
merged 4 commits into from
Jul 6, 2023
Merged

feat: introduce prometheus metrics #54

merged 4 commits into from
Jul 6, 2023

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Jul 6, 2023

Signed-off-by: MrCroxx mrcroxx@outlook.com

close: #52

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the feature New feature or request label Jul 6, 2023
@MrCroxx MrCroxx self-assigned this Jul 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #54 (d1de31b) into main (e61eb5d) will increase coverage by 0.79%.
The diff coverage is 88.11%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   67.24%   68.03%   +0.79%     
==========================================
  Files          30       31       +1     
  Lines        3520     3617      +97     
==========================================
+ Hits         2367     2461      +94     
- Misses       1153     1156       +3     
Impacted Files Coverage Δ
foyer-storage-bench/src/main.rs 0.00% <0.00%> (ø)
foyer-storage/src/store.rs 89.78% <78.12%> (-0.72%) ⬇️
foyer-storage/src/metrics.rs 92.59% <92.59%> (ø)
foyer-storage/src/flusher.rs 83.78% <100.00%> (+1.09%) ⬆️
foyer-storage/src/reclaimer.rs 85.24% <100.00%> (+0.89%) ⬆️

... and 2 files with indirect coverage changes

@MrCroxx MrCroxx merged commit f9548e6 into main Jul 6, 2023
5 checks passed
@MrCroxx MrCroxx deleted the xx/prometheus branch July 6, 2023 06:28
MrCroxx added a commit that referenced this pull request Apr 17, 2024
* feat: introduce prometheus metrics

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

* calc metrics

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

* fix registry metrics

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

---------

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: prometheus metrics support
2 participants